[FIX] AbstractAdapter: GLOB match virtual dir fragments#28
Merged
RandomByte merged 4 commits intomasterfrom Jan 31, 2019
Merged
[FIX] AbstractAdapter: GLOB match virtual dir fragments#28RandomByte merged 4 commits intomasterfrom
RandomByte merged 4 commits intomasterfrom
Conversation
RandomByte
force-pushed
the
glob-match-vir-dir-fragments
branch
from
04d3217 to
5260eb9
Compare
|
|
|
|
RandomByte
force-pushed
the
glob-match-vir-dir-fragments
branch
from
5260eb9 to
2246698
Compare
Member
Author
|
This also occurs in the context of shimming modules as they can define a virtual-only directory structure. Currently, these directories do not appear in the servers directory listing. Reference: https://openui5.slack.com/archives/C0A7QFN6B/p1547648769026200 |
RandomByte
force-pushed
the
glob-match-vir-dir-fragments
branch
from
2246698 to
ac29eef
Compare
Also remove mtime from resources. Unknown why that got added in the first place
RandomByte
force-pushed
the
glob-match-vir-dir-fragments
branch
from
ac29eef to
6d9374c
Compare
RandomByte
force-pushed
the
glob-match-vir-dir-fragments
branch
from
6d9374c to
6e6b70e
Compare
RandomByte
changed the title
Member
Author
|
Just tested and confirmed that this resolves #28 (comment) |
matz3
requested changes
Jan 31, 2019
…tions to top of file
matz3
reviewed
Jan 31, 2019
matz3
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. Required fix for some cases of SAP/ui5-project#4